708-v5.3-net-phylink-remove-netdev-from-phylink-mii-ioctl-emu.patch 1.8 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859
  1. From 4c4323084e9a67210c8d269dceba1be99356c414 Mon Sep 17 00:00:00 2001
  2. From: Russell King <[email protected]>
  3. Date: Tue, 28 May 2019 10:57:18 +0100
  4. Subject: [PATCH 606/660] net: phylink: remove netdev from phylink mii ioctl
  5. emulation
  6. The netdev used in the phylink ioctl emulation is never used, so let's
  7. remove it.
  8. Signed-off-by: Russell King <[email protected]>
  9. Reviewed-by: Andrew Lunn <[email protected]>
  10. Signed-off-by: David S. Miller <[email protected]>
  11. Signed-off-by: Russell King <[email protected]>
  12. ---
  13. drivers/net/phy/phylink.c | 12 ++++--------
  14. 1 file changed, 4 insertions(+), 8 deletions(-)
  15. --- a/drivers/net/phy/phylink.c
  16. +++ b/drivers/net/phy/phylink.c
  17. @@ -1360,8 +1360,8 @@ EXPORT_SYMBOL_GPL(phylink_ethtool_set_ee
  18. *
  19. * FIXME: should deal with negotiation state too.
  20. */
  21. -static int phylink_mii_emul_read(struct net_device *ndev, unsigned int reg,
  22. - struct phylink_link_state *state, bool aneg)
  23. +static int phylink_mii_emul_read(unsigned int reg,
  24. + struct phylink_link_state *state)
  25. {
  26. struct fixed_phy_status fs;
  27. int val;
  28. @@ -1376,8 +1376,6 @@ static int phylink_mii_emul_read(struct
  29. if (reg == MII_BMSR) {
  30. if (!state->an_complete)
  31. val &= ~BMSR_ANEGCOMPLETE;
  32. - if (!aneg)
  33. - val &= ~BMSR_ANEGCAPABLE;
  34. }
  35. return val;
  36. }
  37. @@ -1473,8 +1471,7 @@ static int phylink_mii_read(struct phyli
  38. case MLO_AN_FIXED:
  39. if (phy_id == 0) {
  40. phylink_get_fixed_state(pl, &state);
  41. - val = phylink_mii_emul_read(pl->netdev, reg, &state,
  42. - true);
  43. + val = phylink_mii_emul_read(reg, &state);
  44. }
  45. break;
  46. @@ -1487,8 +1484,7 @@ static int phylink_mii_read(struct phyli
  47. if (val < 0)
  48. return val;
  49. - val = phylink_mii_emul_read(pl->netdev, reg, &state,
  50. - true);
  51. + val = phylink_mii_emul_read(reg, &state);
  52. }
  53. break;
  54. }