950-0631-drm-vc4-hdmi-Move-clock-calculation-into-its-own-fun.patch 2.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687
  1. From 60b7ddb0b3c9d906a20d8a84e527ccf5a792a64b Mon Sep 17 00:00:00 2001
  2. From: Maxime Ripard <[email protected]>
  3. Date: Thu, 2 Dec 2021 17:04:18 +0100
  4. Subject: [PATCH] drm/vc4: hdmi: Move clock calculation into its own
  5. function
  6. The code to compute our clock rate for a given setup will be called in
  7. multiple places in the next patches, so let's create a separate function
  8. for it.
  9. Signed-off-by: Maxime Ripard <[email protected]>
  10. ---
  11. drivers/gpu/drm/vc4/vc4_hdmi.c | 49 +++++++++++++++++++++++-----------
  12. 1 file changed, 34 insertions(+), 15 deletions(-)
  13. --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
  14. +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
  15. @@ -1265,6 +1265,35 @@ vc4_hdmi_encoder_clock_valid(const struc
  16. return MODE_OK;
  17. }
  18. +static unsigned long long
  19. +vc4_hdmi_encoder_compute_mode_clock(const struct drm_display_mode *mode,
  20. + unsigned int bpc)
  21. +{
  22. + unsigned long long clock = mode->crtc_clock * 1000;
  23. +
  24. + if (mode->flags & DRM_MODE_FLAG_DBLCLK)
  25. + clock = clock * 2;
  26. +
  27. + return clock * bpc / 8;
  28. +}
  29. +
  30. +static int
  31. +vc4_hdmi_encoder_compute_clock(const struct vc4_hdmi *vc4_hdmi,
  32. + struct vc4_hdmi_connector_state *vc4_state,
  33. + const struct drm_display_mode *mode,
  34. + unsigned int bpc)
  35. +{
  36. + unsigned long long clock;
  37. +
  38. + clock = vc4_hdmi_encoder_compute_mode_clock(mode, bpc);
  39. + if (vc4_hdmi_encoder_clock_valid(vc4_hdmi, clock) != MODE_OK)
  40. + return -EINVAL;
  41. +
  42. + vc4_state->pixel_rate = clock;
  43. +
  44. + return 0;
  45. +}
  46. +
  47. #define WIFI_2_4GHz_CH1_MIN_FREQ 2400000000ULL
  48. #define WIFI_2_4GHz_CH1_MAX_FREQ 2422000000ULL
  49. @@ -1277,6 +1306,7 @@ static int vc4_hdmi_encoder_atomic_check
  50. struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
  51. unsigned long long pixel_rate = mode->clock * 1000;
  52. unsigned long long tmds_rate;
  53. + int ret;
  54. if (vc4_hdmi->variant->unsupported_odd_h_timings &&
  55. !(mode->flags & DRM_MODE_FLAG_DBLCLK) &&
  56. @@ -1298,21 +1328,10 @@ static int vc4_hdmi_encoder_atomic_check
  57. pixel_rate = mode->clock * 1000;
  58. }
  59. - if (conn_state->max_bpc == 12) {
  60. - pixel_rate = pixel_rate * 150;
  61. - do_div(pixel_rate, 100);
  62. - } else if (conn_state->max_bpc == 10) {
  63. - pixel_rate = pixel_rate * 125;
  64. - do_div(pixel_rate, 100);
  65. - }
  66. -
  67. - if (mode->flags & DRM_MODE_FLAG_DBLCLK)
  68. - pixel_rate = pixel_rate * 2;
  69. -
  70. - if (vc4_hdmi_encoder_clock_valid(vc4_hdmi, pixel_rate) != MODE_OK)
  71. - return -EINVAL;
  72. -
  73. - vc4_state->pixel_rate = pixel_rate;
  74. + ret = vc4_hdmi_encoder_compute_clock(vc4_hdmi, vc4_state, mode,
  75. + conn_state->max_bpc);
  76. + if (ret)
  77. + return ret;
  78. return 0;
  79. }